Allow decimals in % input

[Megumin]

For us that suck at reading books and go very slow, and want to use the % input:

Trello link:

[brandon]

lol oh no. I guess I should allow this right. Approved.

[Megumin]

@brandon Do you think this would be too hard to implement?

I want to keep an accurate record of reading, now the error changed from “This field is required” to “Enter a whole number”

[brandon]

No, I don’t think it’d be too hard to implement. I know, for time spent that’d probably be somewhat critical. I’ll try to do sometime soon.

[brandon]

@Megumin after exploring this a bit more, I think this does pose one issue. If i start to allow decimal percents, I may end up with decimal page counts too. Would you be ok with me rounding to the nearest page for stats? It’s easier if I keep everything as pages in the backend calculations, just save and present a decimal percent on the front end.

Keeping whole pages on the backend calculations means that you will lose some accuracy when it comes to reading speed / page count calculations… but I do think its very minor.

I’d also make the ‘percent’ handling sticky on a per book basis. Let me know what you think.

[eefara]

@brandon

I’d also make the ‘percent’ handling sticky on a per book basis. Let me know what you think.

I would definitely appreciate this!

[Megumin]

@brandon

@Megumin after exploring this a bit more, I think this does pose one issue. If i start to allow decimal percents, I may end up with decimal page counts too. Would you be ok with me rounding to the nearest page for stats? It’s easier if I keep everything as pages in the backend calculations, just save and present a decimal percent on the front end.

It’s what I’m currently doing because it’s still more accurate than loosing 0.XX% in large books. Is not a big issue in smaller ones.

[brandon]

alright, I’ll do what i’m proposing then - I’ll keep rounded page count but allow decimal percents.

[brandon]

Completed!