Bug: shortened review texts don't blur spoiler tags

Description of your request or bug report: Review text spoilers aren’t being blurred when abbreviated review is shown (for long reviews).

Example of ひげひろ review w/ problem

The text after “To elaborate,” should be blurred out. When you click Read More, it blurs properly

Trello link: (leave in blank)

Seconding this; I wrote a short review talking about why I was disappointed with a book, which covers events throughout the book, and all spoilers near that cutoff line are perfectly visible. D:

5 Likes

In case this is helpful: it seems the text is stripped after a certain number of characters, and thus the </Spoiler> closing tag is lost. So then when it gets converted to HTML, the opening <span class="spoiler spoiler-hidden"> never gets generated.

7 Likes

Ah, that does make sense…

Interesting. I wonder what the best way to resolve that is :thinking:

Maybe you still display the whole text, just have the height set and the overflow hidden?

4 Likes

That sounds like a good solution… alternately, if you can do the text stripping after the conversion to HTML has happened, the open <span class="spoiler spoiler-hidden"> tag should just be auto-closed by the browser… but that’s a really hacky way to do things, and your suggested solution is better, imo.

Bumping this cuz it’s still an issue, and in addition to general concern over spoilers, I just wrote up a review that has some potentially triggering content, and I had to really play around with it, to get it to go under the fold, on my phone… (Hoping that will also be sufficient for other devices).

Edit: it actually still isn’t going under, the box just seems to get longer


The bottom paragraph should be entirely blurred

3 Likes

I believe Brandon has it set to go under a read more after a certain number of characters, rather than a certain number of lines.

Setting it to a certain number of lines would be better, I think, and it would also be helpful to be able to manually add a read more. Well, for all I know, there could be HTML or Markdown for it, but all I know is “hide details,” which could work in a pinch, but isn’t really the same.

2 Likes

Ah right, I forgot it was character-based… Unfortunately there’s no such thing (programmatically) as “lines” when it comes to this sort of thing. I think the solution @brandon suggested is perfectly good, if/when he implements it.

“Hide details” is a discourse (forum software) thing. It won’t work for reviews, afaik. Edit: actually <details> and <summary> tags seem to accomplish this!! Thx for the suggestion

I guess I was on Chrome when I tried that before… but this actually doesn’t work on Firefox either :cry:

1 Like

Didn’t find a way to make spoiler / details / summary tags work either. I removed my spoilery review for the book I’ve just finished, I will post it on the forum somewhere and then on Natively a link to that.

2 Likes